Add unreferenced file integration tests#1399
Merged
spencerugbo merged 10 commits intomainfrom Dec 10, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1399 +/- ##
==========================================
- Coverage 86.28% 85.17% -1.12%
==========================================
Files 102 102
Lines 12572 12972 +400
==========================================
+ Hits 10848 11049 +201
- Misses 1248 1438 +190
- Partials 476 485 +9 see 23 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
craigell
reviewed
Nov 19, 2025
test/integration/managementplane/config_apply_unreferenced_files_test.go
Show resolved
Hide resolved
craigell
approved these changes
Nov 25, 2025
craigell
approved these changes
Nov 25, 2025
dhurley
reviewed
Nov 25, 2025
test/integration/managementplane/config_apply_unreferenced_files_test.go
Show resolved
Hide resolved
aphralG
reviewed
Nov 27, 2025
test/integration/managementplane/config_apply_unreferenced_files_test.go
Outdated
Show resolved
Hide resolved
test/integration/managementplane/config_apply_unreferenced_files_test.go
Outdated
Show resolved
Hide resolved
aphralG
reviewed
Dec 3, 2025
aphralG
approved these changes
Dec 4, 2025
dhurley
reviewed
Dec 5, 2025
test/integration/managementplane/config_apply_unreferenced_files_test.go
Show resolved
Hide resolved
test/integration/managementplane/config_apply_unreferenced_files_test.go
Show resolved
Hide resolved
dhurley
reviewed
Dec 10, 2025
dhurley
approved these changes
Dec 10, 2025
Akshay2191
pushed a commit
that referenced
this pull request
Dec 18, 2025
* add unreferenced file support to mock * add integration tests for unreferenced files * address lint issues * add referenced to unreferenced test case * add manifest check to update and delete tests * refactor test cases * fix failing test case * rename manifest helper function * add file existence check to each test case * revert Makefile change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add unreferenced file support to the mock management plane and add integration tests for it.
When sending a config apply request through the mock, the mock looks at the request body to identify unreferenced files. Here is a sample request body of a config apply that contains an unreferenced file:
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)